This makes lint run twice on PRs, I think we only need one run.

This means we have two lint runs?

• Lint / lint / lint
• Tests / lint / lint

They only take about 25 to 45s each, so not too much considering all the rest, but can we have only one run?

It'll make the list of logs easier to look at (which job should I check?), and during busy sprints, the extra jobs can take up a runner, adding some overhead in waiting for a free runner and so on.

Another option is to mark the existing lint job as required in branch protection rules (I can do it).

Either works for me! What do you think is best?

I've added it as a required check for all the branches.

Hang on:

I'll try the "lint / lint" option instead of "lint".

That's better:

Will recheck PRs to the other branches as well.

Hang on again, I shouldn't look at this PR, the "lint" is the one we need! Will flip it back...

Okay, all set, except for 3.10 which doesn't have a lint.yml.

Thanks!

Late to the party, I think this is the change we ideally wanted to make full use of the 'all-green' check. We just needed to completely remove lint.yml rather than gutting it.

We could, but lint.yml is nice and simple, and I would like to avoid putting more complexity in the large build.yml file. Linting and testing are pretty distinct things.

The counter-argument is that the all-green check's sole purpose is to avoid as many required checks as we can by bundling them into one. lint should not be a standalone required check, especially since it's something that we should be able to easily bypass if we really need to. If anything at all goes wrong with linting now, we either have to hack around the configuration to make it lie, or bother someone with admin to remove the requirement. I would argue that lint is less important than testing, but we're now in the situation where it's a less involved process to avoid a broken test than broken linting.

Maybe there's a better arrangement of things, but I don't think the simplicity of lint.yml is an argument in favor of keeping three lines out of a configuration file.

I also wanted to say that we should have a reusable-lint.yml that would be invoked just once and wired into alls-green. Although, I'd prefer a more unified CI refactor in general that I may bring up in July at the EP sprint since I can't contribute meaningfully right now.